Skip to content

examples-automation, run samples publish on js#13512

Merged
weidongxu-microsoft merged 1 commit intoAzure:mainfrom
weidongxu-microsoft:examples-automation_run-samples-publish-on-js
Mar 2, 2026
Merged

examples-automation, run samples publish on js#13512
weidongxu-microsoft merged 1 commit intoAzure:mainfrom
weidongxu-microsoft:examples-automation_run-samples-publish-on-js

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jan 9, 2026

link Azure/azure-sdk-for-js#36757 (comment)

For JS, automation will call pnpm install then npx dev-tool samples publish to generate the JS samples in runtime.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review January 13, 2026 08:59
Copilot AI review requested due to automatic review settings January 13, 2026 08:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds automation to generate JavaScript SDK samples by running pnpm install and npx dev-tool samples publish commands during the examples automation process, as described in the linked GitHub issue.

Changes:

  • Added new tools.py module with publish_samples function to execute pnpm and npx commands
  • Added tools_test.py with a skipped integration test for the new functionality
  • Integrated publish_samples call into the main automation workflow before processing the generated samples

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
tools/azure-rest-api-specs-examples-automation/js/tools.py Implements subprocess wrapper and publish_samples function to run pnpm install and npx dev-tool samples publish commands
tools/azure-rest-api-specs-examples-automation/js/tools_test.py Adds a skipped integration test for the publish_samples function
tools/azure-rest-api-specs-examples-automation/js/main.py Integrates the publish_samples call into the main workflow to generate samples before processing them

@qiaozha qiaozha requested a review from MaryGao January 28, 2026 07:49
@weidongxu-microsoft weidongxu-microsoft merged commit 82f95d3 into Azure:main Mar 2, 2026
12 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the examples-automation_run-samples-publish-on-js branch March 2, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants